Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inputMode to MarkdownTextInput #451

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

christianwen
Copy link
Contributor

Details

This PR is to add inputMode to MarkdownTextInput.web.ts

Related Issues

Expensify/App#10731

Manual Tests

Linked PRs

Copy link

github-actions bot commented Aug 13, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@christianwen
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@christianwen
Copy link
Contributor Author

recheck

Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some checks are failing, please fix them

src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
@christianwen
Copy link
Contributor Author

@Skalakid Can you help review again? Thanks

Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christianwen
Copy link
Contributor Author

@BartoszGrajdek Can you check this PR? Thanks

@Skalakid Skalakid merged commit 1e38063 into Expensify:main Aug 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants